Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Add Spell:Enable Spell Checking File Type command #3060

Closed
Jason3S opened this issue Feb 25, 2024 · 5 comments
Closed

Task: Add Spell:Enable Spell Checking File Type command #3060

Jason3S opened this issue Feb 25, 2024 · 5 comments

Comments

@Jason3S
Copy link
Collaborator

Jason3S commented Feb 25, 2024

The current Spell:Enable Spell Checking Document Language command name is misleading.

See: #3059

Spell:Enable Spell Checking Document Language should be a legacy alias of Spell:Enable Spell Checking Document Type

@memeplex
Copy link

memeplex commented Mar 3, 2024

We already have:

  • LanguageId
  • Filetype
  • Language
  • Locale (although not exposed to VSCode)

Document Type would add yet another name. Why not Spell:Enable Spell Checking Filetype?

@Jason3S
Copy link
Collaborator Author

Jason3S commented Mar 4, 2024

We already have:

  • LanguageId
  • Filetype
  • Language
  • Locale (although not exposed to VSCode)

Document Type would add yet another name. Why not Spell:Enable Spell Checking Filetype?

You make a good point. I added Spell: Enable Spell Checking File Type instead of Document Type.

image

@Jason3S
Copy link
Collaborator Author

Jason3S commented Mar 4, 2024

Fixed with #3078

@Jason3S Jason3S closed this as completed Mar 4, 2024
@Jason3S Jason3S changed the title Task: Add Spell:Enable Spell Checking Document Type command Task: Add Spell:Enable Spell Checking File Type command Mar 4, 2024
@memeplex
Copy link

memeplex commented Mar 4, 2024

Thanks!

Copy link
Contributor

github-actions bot commented Apr 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants