Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change directory of backups after it has been set #157

Closed
candroid-man opened this issue Dec 11, 2021 · 9 comments
Closed

Unable to change directory of backups after it has been set #157

candroid-man opened this issue Dec 11, 2021 · 9 comments
Assignees
Labels
Platform: Mobile Status: Waiting for Release The fix is done but is waiting for release. Type: Feature Request New feature or request
Milestone

Comments

@candroid-man
Copy link
Collaborator

Describe the bug

Once the user selects a directory for encrypted backups, there is no way to change it (both desktop and mobile). In my case, I put it in the wrong place, as I wanted it to be on my SD card. I even went as far as to delete the directory all together hoping that Notesnook would detect that the directory no longer exists, but after manually backing up my data, it just didn't create any files. Disabling and re-enabling the backups does not help. The issue persisted after rebooting the device.

To Reproduce

Steps to reproduce the behavior:

  1. Go to settings
  2. Click on Backup & restore
  3. Select a directory on your device to store the backups
  4. See error

Screenshots

Selection_014

Desktop

  • OS: EndeavourOS Atlantis
  • Browser Electron (AppImage)
  • Version v1.6.11

Smartphone

  • Device: Samsung Galaxy S10+
  • OS: Android 11
  • Browser: Native application
  • Version: v1.6.92

Additional context

If there is a way to change the directory, it is not easily seen from the Backup & restore menu, which is an important thing that needs to be in that menu

@thecodrr
Copy link
Contributor

@candroid-man I don't think I understood what you are trying to do? Do you want to change the directory for the automatic backups? I am trying it on my end (Linux Electron app) and it is working as normal. You just have to enable automatic backups (in settings) to see the option to change the default storage directory.

@candroid-man
Copy link
Collaborator Author

@thecodrr Try it on the mobile version, I didn't actually test it on the desktop version because I assumed that since there was no button to do it, it wouldn't be on either platform. Sorry for the confusion.

@ammarahm-ed
Copy link
Collaborator

ammarahm-ed commented Dec 11, 2021

@thecodrr Try it on the mobile version, I didn't actually test it on the desktop version because I assumed that since there was no button to do it, it wouldn't be on either platform. Sorry for the confusion.

I think there should an option to change backups directory on mobile. This is a feature request. (Android Mainly)

@thecodrr thecodrr added Type: Feature Request New feature or request and removed Type: Bug Something isn't working Platform: Web Platform: Desktop labels Dec 11, 2021
@candroid-man
Copy link
Collaborator Author

candroid-man commented Dec 11, 2021

@thecodrr After trying it on the Linux Electron app, the Change backups storage location button does nothing. The backups are working correctly however.

@thecodrr
Copy link
Contributor

@thecodrr After trying it on the Linux Electron app, the Change backups storage location button does nothing. The backups are working correctly however.

Can you try running the app via Terminal to see if there is an issue popping up? Because it is working fine on my end (it should open Directory Selection dialog).

@candroid-man
Copy link
Collaborator Author

@thecodrr Is that possible using the AppImage?

@thecodrr
Copy link
Contributor

thecodrr commented Dec 11, 2021

@thecodrr Is that possible using the AppImage?

Yes. ./path/to/AppImage. You might have to chmod +x path/to/AppImage first.

@candroid-man
Copy link
Collaborator Author

@thecodrr Sure enough, there is an error:

Checking for update
(node:168868) ExperimentalWarning: buffer.Blob is an experimental feature. This feature could change at any time
(Use `Notesnook --trace-warnings ...` to show where the warning was created)
Update for version 1.6.11 is not available (latest version: 1.6.11, downgrade is disallowed).
[168868:1211/013950.054250:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

@thecodrr
Copy link
Contributor

[168868:1211/013950.054250:ERROR:browser_main_loop.cc(269)] Gtk: gtk_native_dialog_run: assertion '!priv->visible' failed

This is the error. Seems to be an issue with electron with a potential fix mentioned here

@thecodrr thecodrr added this to In progress in Improve reliability Dec 13, 2021
@thecodrr thecodrr added Status: Waiting for Release The fix is done but is waiting for release. and removed Status: Investigating We are investigating the bug. labels Dec 13, 2021
@thecodrr thecodrr moved this from In progress to Done in Improve reliability Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Mobile Status: Waiting for Release The fix is done but is waiting for release. Type: Feature Request New feature or request
Projects
Development

No branches or pull requests

3 participants