Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Succeed quickly in Eventually, EventuallyWithT #1424

Open
cszczepaniak opened this issue Jul 13, 2023 · 2 comments
Open

Succeed quickly in Eventually, EventuallyWithT #1424

cszczepaniak opened this issue Jul 13, 2023 · 2 comments
Labels
assert.Eventually About assert.Eventually/EventuallyWithT enhancement pkg-assert Change related to package testify/assert under consideration

Comments

@cszczepaniak
Copy link

cszczepaniak commented Jul 13, 2023 •
edited

assert.Eventually does not check initially whether the condition is satisfied. This means it must wait a minimum of the tick duration before checking the condition for the first time. It would be a nice optimization to early-out if the condition is met already when the function is called.
@cszczepaniak cszczepaniak mentioned this issue Jul 15, 2023
Open
@dolmen dolmen added enhancement under consideration pkg-assert Change related to package testify/assert labels Jul 25, 2023
@dolmen
Copy link
Collaborator

dolmen commented Jul 25, 2023

I think this is a good behavior change.

We must involve people who designed it.

@cszczepaniak cszczepaniak mentioned this issue Jul 30, 2023
Open
@cszczepaniak
Copy link
Author

This would be addressed by the proposal in #1439 if that were to move forward.

@dolmen dolmen added the assert.Eventually About assert.Eventually/EventuallyWithT label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert.Eventually About assert.Eventually/EventuallyWithT enhancement pkg-assert Change related to package testify/assert under consideration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dolmen @cszczepaniak