Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnythingOfType is marked deprecated on pkgsite #1573

Open
brackendawson opened this issue Mar 8, 2024 · 1 comment
Open

AnythingOfType is marked deprecated on pkgsite #1573

brackendawson opened this issue Mar 8, 2024 · 1 comment
Labels

Comments

@brackendawson
Copy link
Collaborator

brackendawson commented Mar 8, 2024

Description

On pkgsite mock.AnythingOfType is marked as deprecated.

mock.AnythingOfTypeArgument was marked deprecated by #1441. But because AnythingOfType is a factory function for AnythingOfTypeArgument and factory functions are shown nested under the type, this gets deprecated too.

This is problematic because the AnythingOfTypeArgument deprecation notice says to use AnythingOfType.

Running pkgsite locally shows this is fixed if AnythingOfType returns the unexported anythingOfTypeArgument, as it's a type alias that shouldn't be a breaking change.

My VSCode doesn't reflect this:
image

Step To Reproduce

View public docs for mock package on pkgsite

Expected behavior

AnythingOfTypeArgument deprecated, AnythingOfType not.

Actual behavior

Both deprecated.

@dolmen
Copy link
Collaborator

dolmen commented Apr 1, 2024

This will be fixed by #1578.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants