Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a proper error message when we have type mismatching #155

Closed
kostyantyn opened this issue Apr 21, 2015 · 3 comments
Closed

Return a proper error message when we have type mismatching #155

kostyantyn opened this issue Apr 21, 2015 · 3 comments

Comments

@kostyantyn
Copy link

It took a lot of time to understand this broken test

--- FAIL: TestClickEvent (0.00s)
    Location:   click_test.go:70
    Error:      Not equal: 2 (expected)
                    != 2 (actual)

and the reason was that those values had different types: int32 and int.

Would be really good to return a proper error message.

@matryer
Copy link
Member

matryer commented Apr 21, 2015

Maybe if both values are the same, we include the type? Or include the type always?

@jonahkagan
Copy link

👍 this behavior changed recently and caused very confusing test failures

@mpictor
Copy link

mpictor commented May 29, 2015

Making it more strict about types is good, but doing so without printing types is bad!

👍 on this creating confusing test failures and needing to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants