Fix the network-policies handling when metrics config from CM is used #4261
+526
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Jan 18, 2021
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/ModelUtils.java
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
sknot-rh
approved these changes
Jan 18, 2021
cluster-operator/src/test/java/io/strimzi/operator/cluster/model/ModelUtilsTest.java
Outdated
Show resolved
Hide resolved
...r-operator/src/test/java/io/strimzi/operator/cluster/model/KafkaMirrorMaker2ClusterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
ppatierno
approved these changes
Jan 18, 2021
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
added a commit
that referenced
this pull request
Jan 18, 2021
…#4261) * Fix the network-policies handling when metrics config from CM is used Signed-off-by: Jakub Scholz <www@scholzj.com> * Add Javadoc Signed-off-by: Jakub Scholz <www@scholzj.com> * Review comemnts I Signed-off-by: Jakub Scholz <www@scholzj.com> * Review Comments II Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
When the new metrics configuration from ConfigMap is used, the Prometheus JMX Exporter port is not opened properly on the network policies and that makes the metrics not accessible. This PR properly sets the
metricsEnabledvalue when one of the currently supported options is used.This is a bug in the 0.21.0 release. It needs to be backported to 0.21 release branch and we need to do 0.21.1 release.
Checklist