Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the network-policies handling when metrics config from CM is used #4261

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Jan 17, 2021

Type of change

  • Bugfix

Description

When the new metrics configuration from ConfigMap is used, the Prometheus JMX Exporter port is not opened properly on the network policies and that makes the metrics not accessible. This PR properly sets the metricsEnabled value when one of the currently supported options is used.

This is a bug in the 0.21.0 release. It needs to be backported to 0.21 release branch and we need to do 0.21.1 release.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Sorry, something went wrong.

Signed-off-by: Jakub Scholz <www@scholzj.com>
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added the bug label Jan 17, 2021
@scholzj scholzj added this to the 0.22.0 milestone Jan 17, 2021
@scholzj scholzj requested review from sknot-rh and a team January 17, 2021 22:01
@scholzj
Copy link
Member Author

scholzj commented Jan 17, 2021

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Jakub Scholz <www@scholzj.com>
Copy link
Member

@sknot-rh sknot-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, otherwise LGTM

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj
Copy link
Member Author

scholzj commented Jan 18, 2021

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit dd4f3c6 into strimzi:master Jan 18, 2021
@scholzj scholzj deleted the fix-network-policies-for-config-map-metrics branch January 18, 2021 17:18
scholzj added a commit that referenced this pull request Jan 18, 2021
…#4261)

* Fix the network-policies handling when metrics config from CM is used

Signed-off-by: Jakub Scholz <www@scholzj.com>

* Add Javadoc

Signed-off-by: Jakub Scholz <www@scholzj.com>

* Review comemnts I

Signed-off-by: Jakub Scholz <www@scholzj.com>

* Review Comments II

Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants