fix(vue-tsx): support parsing tsx script in .vue file (issue#2849) #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyangxu
changed the title
|
Hi, @zeyangxu thanks for the thorough bug report. You even brought your own fix, which is awesome 👍 I started writing down review comments but had to test a bunch of stuff out myself and ended up implementing the improvements, hope you don't mind 😅, see zeyangxu#1 Please look through them and, if you agree, merge them. After that, I'll merge this PR. I've tested the code change out on your example project and it worked out nicely. |
PR review comments
nicojs
approved these changes
May 6, 2021
|
Thanks again! ♥ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2849