Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom renovate config for parsing libman.json for mutation-testing-elements updates #2862

Open
rouke-broersma opened this issue Mar 1, 2024 · 4 comments · May be fixed by #2902
Open

Custom renovate config for parsing libman.json for mutation-testing-elements updates #2862

rouke-broersma opened this issue Mar 1, 2024 · 4 comments · May be fixed by #2902
Labels
🚀 Feature request New feature or request good first issue hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@rouke-broersma
Copy link
Member

Is your feature request related to a problem? Please describe.
We don't often update mutation-testing-elements because we don't notice there are changes. Renovate does not by default understand libman.json files, so it can't notify us of updates to the package.

Describe the solution you'd like
Implement a custom manager so renovate understands libman.json files as npm packages: https://docs.renovatebot.com/modules/manager/regex/

@rouke-broersma rouke-broersma added 🚀 Feature request New feature or request hacktoberfest https://hacktoberfest.digitalocean.com good first issue labels Mar 1, 2024
@hanahbaker1
Copy link

Hi there, I found this issue on GFI, and as you probably gather I'm new to opensource.
Would this be your solution and if so how can I push a PR to help with this? Thanks for your help and pointers 👍

    {
      "customType": "regex",
      "fileMatch": ["^libman\\.json$"],
      "matchStrings": [
        "\"library\": \"mutation-testing-elements\",\n\\s*\"version\": \"(?<currentValue>.*?)\""
      ],
      "depName": "mutation-testing-elements",
      "datasourceTemplate": "npm"
    }
  ] ```
  

@rouke-broersma
Copy link
Member Author

rouke-broersma commented Apr 3, 2024

Hi @hanahbaker1! And welcome to open source!

Without digging into it (I'm on leave at the moment) this seems like the solution I had in mind. You can contribute this change by editing the renovate.json located in the .github folder https://github.com/stryker-mutator/stryker-net/blob/master/.github%2Frenovate.json . Github should then suggest you create a fork of the repo and then submit a pull request. Once you've done that and once I'm back from leave I'll verify the change works as expected and if necessary request that you make some changes. Afterwards I'll approve the pull request and your change will be merged.

Does that help you to get on your way?

@hanahbaker1
Copy link

Thanks for the guidance and info @rouke-broersma 😄 I've created the PR, but need to fix the build some time this week.

@rouke-broersma
Copy link
Member Author

Don't worry about the build, that's my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature or request good first issue hacktoberfest https://hacktoberfest.digitalocean.com
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants