fix(jasmine): support jasmine >3.6.2 (#2594)

Correctly handle async errors from `jasmine.execute` (returns a never resolving promise since jasmine 3.6.2)
stryker-mutator · Jan 15, 2021 · 582079b · 582079b
1 parent 04cf519
commit 582079b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 56 deletions.
diff --git a/e2e/package-lock.json b/e2e/package-lock.json
diff --git a/e2e/package.json b/e2e/package.json
@@ -16,7 +16,7 @@
     "chai-as-promised": "~7.1.1",
     "cross-env": "~5.2.0",
     "grunt": "~1.0.4",
-    "jasmine": "~3.6.1",
+    "jasmine": "~3.6.2",
     "jasmine-core": "~3.6.0",
     "jest": "~26.4.2",
     "jest-environment-jsdom-sixteen": "^1.0.3",

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
     "execa": "~5.0.0",
     "glob": "~7.1.1",
     "install-local": "^3.0.1",
-    "jasmine": "3.6.1",
+    "jasmine": "~3.6.2",
     "jasmine-core": "~3.6.0",
     "json-schema-to-typescript": "~10.1.0",
     "lerna": "~3.22.1",

diff --git a/packages/jasmine-runner/src/jasmine-test-runner.ts b/packages/jasmine-runner/src/jasmine-test-runner.ts
@@ -97,7 +97,12 @@ export class JasmineTestRunner implements TestRunner {
       };
 
       jasmine.env.addReporter(reporter);
-      jasmine.execute();
+      const maybePromise = jasmine.execute();
+      if (maybePromise) {
+        maybePromise.catch((err) => {
+          runTask.reject(err);
+        });
+      }
       const result = await runTask.promise;
       return result;
     } catch (error) {