Add a json reporter #2582
Merged
Add a json reporter #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicojs
requested changes
Oct 28, 2020
nicojs
reviewed
Oct 29, 2020
|
Ok, finally found some time to fix the remarks: Added some unit tests, removed the indention option and adjusted some things you commented on in the analog pr #2601 which were also present in my pr. I've also added the option for a custom filename besides the custom path. |
nicojs
approved these changes
Nov 5, 2020
|
Thanks! 👍 |
|
Many thanks for the feature @Tummerhore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1814. The implementation is relatively simple and copies most of the code from the html reporter. Probably this can be refactored at some point so that there is less duplicated logic. But it works for now.