Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jasmine): support jasmine >3.6.2 #2594

Merged
merged 4 commits into from Jan 15, 2021
Merged

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Oct 30, 2020

Await the jasmine.execute function

Fixes #2580

Await the `jasmine.execute` function
@nicojs
Copy link
Member Author

nicojs commented Oct 30, 2020

@hugo-vrijswijk this was the reason the CI broke during the hacktoberfest hackathon 🤷‍♂️

@nicojs nicojs changed the title feat(jasmine): support jasmine 3.6.2 feat(jasmine): support jasmine >3.6.2 Jan 15, 2021
@nicojs nicojs changed the title feat(jasmine): support jasmine >3.6.2 fix(jasmine): support jasmine >3.6.2 Jan 15, 2021
@nicojs nicojs enabled auto-merge (squash) January 15, 2021 20:13
@nicojs nicojs merged commit 582079b into master Jan 15, 2021
@nicojs nicojs deleted the feat/support-jasmine-3.6.2 branch January 15, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jasmine 3.6.2 breaks the jasmine runner.
1 participant