Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(instrumenter): offset location in mutant collector instead of html parser #2790

Merged
merged 1 commit into from Mar 11, 2021
Merged

fix(instrumenter): offset location in mutant collector instead of html parser #2790

merged 1 commit into from Mar 11, 2021

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Mar 9, 2021

Fixes #2775

@Djaler
Copy link
Contributor Author

Djaler commented Mar 9, 2021

So, here I am, @nicojs

nicojs
nicojs requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Djaler. I've got 2 small remarks.

packages/instrumenter/test/unit/parsers/html-parser.spec.ts Show resolved Hide resolved
packages/instrumenter/src/transformers/mutant-collector.ts Outdated Show resolved Hide resolved
nicojs
nicojs requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. I've found 2 more issues while looking more closely. Would you mind taking a look if you have the time? ❤

packages/instrumenter/src/transformers/mutant-collector.ts Outdated Show resolved Hide resolved
@Djaler
Copy link
Contributor Author

Djaler commented Mar 10, 2021

Fixed

@nicojs
Copy link
Member

nicojs commented Mar 10, 2021

Thanks! I'll have another look tomorrow

@nicojs nicojs self-requested a review March 11, 2021 07:10
nicojs
nicojs approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and the issue seems resolved 😎

image

@nicojs nicojs merged commit 547a25c into stryker-mutator:master Mar 11, 2021
This was referenced Mar 12, 2021
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect results with vue SFC
2 participants
@Djaler @nicojs