Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost every PR analysis results in: "needs-review" or "needs-careful-review" #171

Open
zsso opened this issue Feb 2, 2023 · 1 comment

Comments

@zsso
Copy link

zsso commented Feb 2, 2023

Hi, I'm testing your tool, but looks like result is almost the same every time: "needs-review" or "needs-careful-review"

Even when there are only minor changes, like:
image

Or:
image

The only change that got approved was:
image

Am I doing something wrong?

UPDATE:

Looks like this happens when I add additional minor changes to PR and it gets re-analized. If all the minor changes are in the same commit, they are approved, if not rejected...

approved:
image

needs-review
image

@zsso zsso changed the title Every PR analysis results in: "needs-review" or "needs-careful-review" Almost every PR analysis results in: "needs-review" or "needs-careful-review" Feb 2, 2023
@e8-HongJunLiu
Copy link

@zsso I also encountered the same problem, I just add or change a note, it will not automatically approve, the following is my action:

name: Codeball
on:
pull_request: {}

on: [pull_request]

jobs:
codeball_job:
runs-on: ubuntu-latest
name: Codeball
steps:
- name: Codeball
uses: sturdy-dev/codeball-action@v2

uses: sturdy-dev/codeball-action/approver/@v2

    with:
      GITHUB_TOKEN: ${{ secrets.CODEBALL_BOT_TOKEN }}
      approvePullRequests: "true"
      labelPullRequestsWhenApproved: "true"
      labelPullRequestsWhenReviewNeeded: "true"
      failJobsWhenReviewNeeded: "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants