Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Filter with an integer range #915

Open
wash34000 opened this issue Sep 3, 2019 · 7 comments
Open

Filter with an integer range #915

wash34000 opened this issue Sep 3, 2019 · 7 comments
Labels

Comments

@wash34000
Copy link

Is it possible to make a number filter with two inputs : one for minimal and one for maximal value ?

@stephanvierkant
Copy link
Collaborator

Interesting feature request! There is a DateRangePicker, but there is no NumberRange filter.

@wash34000
Copy link
Author

I'll love it ...

@stephanvierkant
Copy link
Collaborator

Feel free to open a PR ;)

I can help with the server side implementation. But how would the client side look like? There is a DateRangePicker, but how would a numberrangepicker look like?

@wash34000
Copy link
Author

wash34000 commented Sep 4, 2019

image
Like this.

What do you think about this one with two input tags ?

I've all ready make this with an old Datatables version on CakePHP framework.
If that can help you a i can share this code ?

Feel free to open a PR ;)

I can help with the server side implementation. But how would the client side look like? There is a DateRangePicker, but how would a numberrangepicker look like?

What is a PR ? :(

Edit by Stephan: I've merged your comments, there is no need to place a new comment a minute after the other one.

Repository owner deleted a comment from wash34000 Sep 4, 2019
Repository owner deleted a comment from wash34000 Sep 4, 2019
@stephanvierkant
Copy link
Collaborator

A PR is a Pull Request, but if you don't know what it is, I don't think you'll be able to create one ;).

If you take a look at this code, you'll see what the DateRange looks like: https://github.com/stwe/DatatablesBundle/blob/master/Datatable/Filter/DateRangeFilter.php. The NumberRangeFilter should look like this, except it uses numbers instead of dates.

@Seb33300
Copy link
Collaborator

Seb33300 commented Sep 4, 2019

And an idea could be to create a RangeFilter (abstract?) class and use it in DateRangeFilter and IntegerRangeFilter so that all shared code will not be duplicated.
And it will be easier in the future to add another range filter if required.

@emullaraj
Copy link
Contributor

A "slider" filter existed before version 1.0, which was not ported in the v1.0 release. If anyone is interested in porting the filter, here is the link to v0.13: filter_slider.html.twig
#346 #548

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants