Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSS in head #445

Open
XhmikosR opened this issue Nov 13, 2019 · 3 comments
Open

Move CSS in head #445

XhmikosR opened this issue Nov 13, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@XhmikosR
Copy link
Contributor

This should allow us to make further optimizations (autoprefixer, minification etc).

Also, we could try moving the results CSS to a separate file so that it's cached, and keep the index page CSS inlined.

Just thinking out loud BTW :)

Another gain will be that we'll have one place to handle the CSS (minus the bars height/width and any other inline styles that cannot be moved of course)

@JB1905
Copy link
Contributor

JB1905 commented Nov 13, 2019

Hi!
I also think that types of style should be unified.
What about solutions such as Styled Components?

@styfle
Copy link
Owner

styfle commented Nov 13, 2019

Does it work with TypeScript? I want to catch typos in styles.

@JB1905
Copy link
Contributor

JB1905 commented Nov 13, 2019

Does it work with TypeScript? I want to catch typos in styles.

It works only with props passed to styled component.
https://www.styled-components.com/docs/api#typescript

However, there is available stylelint extension for Styled Components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants