Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix object syntax css prop, support more types of components & custom elements #229

Merged
merged 5 commits into from
Jun 26, 2019

Conversation

quantizor
Copy link
Collaborator

@quantizor quantizor commented Jun 25, 2019

Reduced version of #228 since the injection location code isn't totally ready yet

  1. fix transpilation of objects being passed into the css prop

  2. modifications from @bpierre to support custom elements, lowercase component variable names with dots, nested component names with dots

Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, amazing work!! 🔥

@quantizor quantizor merged commit 733118f into master Jun 26, 2019
@quantizor quantizor deleted the changes-revised branch June 26, 2019 16:59
@quantizor
Copy link
Collaborator Author

Going to take a second pass at #228 tonight and see if I can get it working consistently before I cut another patch release. If I can't get it where it needs to be will do a patch with these changes tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants