Fix importName type confusion (string, bool, node)
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently `importName` can have many different types: styled-components#232 (comment) This commit ensures that the check whether the name is in the scope (bindings) does not break on plain strings. Closes: styled-components#232
ZauberNerd
added a commit
to xing/hops
that referenced
this pull request
Jul 1, 2019
The `babel-plugin-styled-components` introduced a bug in v1.10.3 which causes our builds to get stuck endlessly. This commit temporarily restricts the version range of the babel plugin to the safe versions until the bug is fixed upstream. See this PR and its linked issue for more details: styled-components/babel-plugin-styled-components#233
ZauberNerd
added a commit
to xing/hops
that referenced
this pull request
Jul 1, 2019
The `babel-plugin-styled-components` introduced a bug in v1.10.3 which causes our builds to get stuck endlessly. This commit temporarily restricts the version range of the babel plugin to the safe versions until the bug is fixed upstream. See this PR and its linked issue for more details: styled-components/babel-plugin-styled-components#233
quantizor
approved these changes
Jul 1, 2019
|
@ZauberNerd I know this is a couple years later, but are you still around to talk about this? I'm confused by this line of code: It seems to me that this will always evaluate to true. Either Should it be: or maybe a |
|
@agriffis looks like you're correct and it was an oversight on my part. |
|
@ZauberNerd Thanks for the reply! Not sure yet about next steps on this, I think any change in this area would deserve additional tests to make sure it's working as intended. But I appreciate your following up to my question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently
importNamecan have many different types:#232 (comment)
This commit ensures that the check whether the name is in the scope
(bindings) does not break on plain strings.
Closes: #232