Support Spread Element #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@probablyup ptal when you get a chance |
|
It would be great to have this merged. |
|
@probablyup - friendly bump on this |
quantizor
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Spread operator does not work. See the following issue for more details: #235.
This fails as the transpiler tries to convert the SpreadElement node into a key/value. Additionally, it needs to ensure that objects are converted into a p
Change
Test Plan
Added a new test case that validates spread elements and nested spread elements are handled properly. The gen code looks correct, but I'm not too familiar with what styled components gen code should look like.