merge existing withConfig arguments to allow SSR when using shouldForwardProp

[ithinkdancan]

Resolves issue #322 where if you have an existing withConfig on your component in order to leverage shouldForwardProp babel was not adding a displayName or componentId

this takes the existing expression adds the additional args and replaces the existing withConfig

[leon-dunamu]

I think "optional chaining" improves the readability of the code. How about applying this?

[ithinkdancan]

I think "optional chaining" improves the readability of the code. How about applying this?

@1Seok2 I did not see optional chaining used anywhere else in the code so i instead matched convention with what was there. I assume thats intentional to support versions of node that do not support chaining.

[ithinkdancan]

@probablyup can I get a review on this?

[quantizor]

@ithinkdancan sorry for the delay in reviewing, can you also add a test case for withConfig and attrs being used together?

[ithinkdancan]

@probablyup added. works as expected if withConfig is after attrs, seems to have issues if they are swapped and you get 2 withConfigs. could maybe use some ideas on how to remedy that

[quantizor]

@probablyup added. works as expected if withConfig is after attrs, seems to have issues if they are swapped and you get 2 withConfigs. could maybe use some ideas on how to remedy that

Hmm that won't work, we need it to work in both places or at least before, per the docs:

Keep in mind that, as in this example, other chainable methods should always be executed after .withConfig.

https://styled-components.com/docs/api#shouldforwardprop

[ithinkdancan]

@probablyup good call out, I have updated the code to be a little smarter about merging the withConfig arguments

[quantizor]

TY

[quantizor]

@ithinkdancan could you merge from main to get the tests running? Just enabled actions for forks. TY!

[ithinkdancan]

@probablyup rebased onto main and pushed it up.

[quantizor]

@probablyup rebased onto main and pushed it up.

Awesome, thank you.

[quantizor]

@ithinkdancan waiting on a couple other small PRs and then will cut a release with this in it, thanks for your contribution!