When there are multiple assignments perfer the outer name. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
commented
Sep 14, 2021
| @@ -10,7 +10,7 @@ export default t => path => { | |||
| let namedNode | |||
|
|
|||
| path.find(path => { | |||
| // const X = styled | |||
| // X = styled | |||
There was a problem hiding this comment.
This was backwards see: https://astexplorer.net/#/gist/3e299bf92f4651d5230a94ef129e5509/latest
| // want to pick the outer name because react-refresh will add HMR variables | ||
| // like this: X = _a = styled. We could also consider only doing this if the | ||
| // name starts with an underscore. | ||
| if (namedNode && !path.isAssignmentExpression()) return true |
There was a problem hiding this comment.
I'm also open to hiding this behavior behind a config option as well.
quantizor
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running styled-components within metro for react native - and metro runs it's babel plugins before ours. One of the plugins that runs is the HMR module (react-refresh), which changes our styled components from:
into the following:
In this case this plugin assigns the view the name of _c0 and it's preferred to use
Test. So I've patched thegetNamefunction to keep traversing if it's the the inner assignment and prefer the outer name. It still falls back to the inner name however.