Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Styled Components v4 breaks snapshots #223

Closed
daraclare opened this issue Jan 11, 2019 · 2 comments
Closed

Migrate to Styled Components v4 breaks snapshots #223

daraclare opened this issue Jan 11, 2019 · 2 comments

Comments

@daraclare
Copy link

daraclare commented Jan 11, 2019

Hi, thanks for a great library :)

I've updated to Styled Components v4, and while everything seems to be fine, the snapshots have broken, but only the styling. Could this be a jest-styled-components issue? I don't want to update any snapshots until I really understand what the changes are.

I've included an image below — a lot of the changes seem to be to class names i.e. from c1 to c0, but there is also removed styles which appear further down, see attached. Anyone know why this is happening? Any advice would be much appreciated!

screen shot 2019-01-11 at 16 02 12

@daraclare
Copy link
Author

Is this related to #191 ?

@quantizor
Copy link
Contributor

Sometimes major versions of styled-components include changes to how and when we generate dynamic styles. As long the styles are all present in the revised snapshots (perhaps grouped differently), I wouldn't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants