Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix doesn't output the same value as vanilla SCSS #613

Open
ivanlori opened this issue Apr 11, 2022 · 1 comment
Open

Mix doesn't output the same value as vanilla SCSS #613

ivanlori opened this issue Apr 11, 2022 · 1 comment

Comments

@ivanlori
Copy link

ivanlori commented Apr 11, 2022

  • polished version: 4.1.0 and 4.2.2
  • JSS-in_CSS library and version: styled-components 5.2.1
  • Any relevant JS library and version: React 16.0.0

Mixin/Helper/Shorthand Usage

mix(0.80, '#000000', '#A4A8B1')

What You Are Seeing

Output exa value: #202123

What You Expected To See

With vanilla SCSS

mix(#000000, #A4A8B1, 80%);

The output exa value is: #212223

@bhough
Copy link
Contributor

bhough commented Apr 14, 2022

Verified this is the case. However, this difference holds true all the way back to polished v1.0. We need to do some more investigation into where the formula is different (this was originally copied directly from SaaS). We also need to see if it is always off, or just for certain cases. Since it has been this way from the beginning, it would be a breaking change. Will keep this issue updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants