Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(esm): modify rollup.config.js and package.json for better ESM packaging #650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

build(esm): modify rollup.config.js and package.json for better ESM packaging #650

wants to merge 3 commits into from

Conversation

tkamenoko
Copy link

fix #649

@tkamenoko
style(rollup.config.js): run prettier formatting
f2b35d7
@tkamenoko
fix(rollup.config.js): explicitly import node:path module
d3b760f
@tkamenoko
build(package.json, rollup.config.js): fix esm build to meet Node.js …
51db107 
…standard

To meet Node.js standard, 2 things should be fixed:

* ESM file should use `.mjs` extention
instead of `.esm.js`.
* `module` field in `package.json` is not standard way of Node.js. Use
`exports` field instead.

fix styled-components#649
@tkamenoko tkamenoko requested a review from bhough as a code owner March 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhough bhough Awaiting requested review from bhough bhough is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use exports field with .mjs extension instead of "module": "dist/polished.esm.js" in package.json
1 participant
@tkamenoko