Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing isolated view doesn't return to correct location when using sections #1479

Closed
prevuelta opened this issue Nov 18, 2019 · 3 comments · Fixed by #1627
Closed

Closing isolated view doesn't return to correct location when using sections #1479

prevuelta opened this issue Nov 18, 2019 · 3 comments · Fixed by #1627
Assignees
@elevatebart
Labels
bug help wanted released

Comments

@prevuelta
Copy link

prevuelta commented Nov 18, 2019 •
edited

Current behavior

When I view a component in isolated view then close it returns to root not to the component (when using sections)

To reproduce

View isolated component then return

Expected behavior

Return to component I was viewing. eg. #/Forms?id=form but returns me to #/form
@prevuelta prevuelta changed the title Closing isolated view doesn't return to correct location Closing isolated view doesn't return to correct location when using sections Nov 20, 2019
@sapegin
Copy link
Member

sapegin commented Dec 10, 2019

Feel free to send a pull request with a fix 👾

@elevatebart elevatebart self-assigned this Jul 12, 2020
@elevatebart
Copy link
Collaborator

This one is not easy since it means changing how the Urls are built.
We need to add to each component/section the calculated url, so that we can share the urls and slugs between sidebar "TableOfContents" and "IsolateButton".

@sapegin, I will try a PR. I hope it can be resolved soon.

@elevatebart elevatebart mentioned this issue Jul 12, 2020
Merged
sapegin pushed a commit that referenced this issue Jul 22, 2020
fix: Correct behavior of the link closing isolated view (#1627)
9b6b6f6 
Fixes #1479
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elevatebart elevatebart

Labels
bug help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: closing isolated vue styleguidist/react-styleguidist
4 participants
@sapegin @prevuelta @elevatebart @styleguidist-bot