fix: closing isolated vue #1627
Conversation
| @@ -26,49 +26,46 @@ exports[`should filter list when search field contains a query 1`] = ` | |||
| searchTerm="" | |||
There was a problem hiding this comment.
Let's get rid of these snashots — they aren't really testing anything ;-/ We used to have way too many but there's no reason to keep them ;-)
I think it's fine ;-) |
Codecov Report
|
|
Hello @sapegin, I hope you are well. |
|
The code is good now but I still see changes in a gigantic snapshot that I'd love to remove entirely ;-) |
Snapshots replaced with real RTL tests. I hope you like them. |
| expect(getAllByTestId('rsg-toc-link').length).toBe(6); | ||
| fireEvent.change(getByPlaceholderText('Filter by name'), { target: { value: searchTerm } }); | ||
| expect(getAllByTestId('rsg-toc-link').length).toBe(1); | ||
| expect(getByTestId('rsg-toc-link').innerHTML).toBe('Forms'); |
There was a problem hiding this comment.
| expect(getByTestId('rsg-toc-link').innerHTML).toBe('Forms'); | |
| expect(getByTestId('rsg-toc-link')).toHaveTextContent('Forms'); |
| expect(actual).toMatchSnapshot(); | ||
| expect(getAllByTestId('rsg-toc-link').length).toBe(6); | ||
| fireEvent.change(getByPlaceholderText('Filter by name'), { target: { value: searchTerm } }); | ||
| expect(getAllByTestId('rsg-toc-link').length).toBe(1); |
There was a problem hiding this comment.
| expect(getAllByTestId('rsg-toc-link').length).toBe(1); | |
| expect(getAllByTestId('rsg-toc-link')). toHaveLength(1); |
| ); | ||
|
|
||
| expect(actual).toMatchSnapshot(); | ||
| expect(getAllByTestId('rsg-toc-link').length).toBe(6); |
There was a problem hiding this comment.
| expect(getAllByTestId('rsg-toc-link').length).toBe(6); | |
| expect(getAllByTestId('rsg-toc-link')).toHaveLength(6); |
|
Agreed! Updated a few matchers |
|
Yay, merging! 🦄 |
|
🎉 This PR is included in version 11.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #1479
Remark For technical reasons, I had to remove the return from isolate button here: I could not access
hrefwithout going through a context or a prop train.It looked logical to me: If there was only one action it should not be in two places.
With this change, it would be only on the top right. Tell me if you need a fix for it.