Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken assetsDir due to updated copy-webpack-plugin #1690

Merged
merged 3 commits into from Sep 8, 2020
Merged

Fix broken assetsDir due to updated copy-webpack-plugin #1690

merged 3 commits into from Sep 8, 2020

Conversation

swashata
Copy link
Contributor

@swashata swashata commented Sep 8, 2020

Because copy-webpack-pluign was updated, the assetsDir was broken. We need to update the config being passed to the plugin to make it work again. Update the plugin to latest version 6.1.0 and update the config and tests to make it work.

  • Update copy-webpack-plugin to ^6.1.0.
  • Fix configuration passed to copy-webpack-plugin [make-webpack-config.ts:111].
  • Update tests to reflect new changes.
  • Fix a non-relevant failing tests in highlightCode.spec.ts so that build passes.

Fixes #1676

Because copy-webpack-pluign was updated, the assetsDir was broken.
We need to update the config being passed to the plugin to make it
work again. Update the plugin to latest version 6.1.0 and update
the config and tests to make it work.
Error message was updated in code, but not in tests.
@swashata swashata changed the title WIP: Fix broken assetsDir Fix broken assetsDir due to updated copy-webpack-plugin Sep 8, 2020
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #1690 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/scripts/make-webpack-config.ts 100.00% <100.00%> (ø)

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny suggestion.

src/scripts/make-webpack-config.ts Outdated Show resolved Hide resolved
Since we don't have the latest types right now
we have to cast to any. Once the types are released
we can remove it.

Co-authored-by: Artem Sapegin <artem@sapegin.ru>
@swashata
Copy link
Contributor Author

swashata commented Sep 8, 2020

@sapegin Done.

@sapegin sapegin merged commit 43e19df into styleguidist:master Sep 8, 2020
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 11.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assetsDir broken in 11.0.9 with create-react-app
3 participants