Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch internals to Mdx #1712

Closed
sapegin opened this issue Nov 11, 2020 · 2 comments
Closed

Switch internals to Mdx #1712

sapegin opened this issue Nov 11, 2020 · 2 comments

Comments

@sapegin
Copy link
Member

sapegin commented Nov 11, 2020

I've made a quick prototype using Mdx as a base for rendering Markdown and examples, and looks like it has some benefits over the current approach:

  • The overall architecture seems simpler (this might be because I'm doing it now, and the current approach has five-years-old roots ;-)
  • Less code to maintain.
  • We'll be able to support both Styleguidst Markdown and Mdx in the future.

Some notes:

  • This doesn't mean we'll be able to load Storybook Mdx directly, since we're not going to emulate their components.
  • This will be a breaking change even for Styleguidst Markdown, though I expect most files will not require changes.

Related issues: #1497.

Rull request: #1720.

@stale
Copy link

stale bot commented Jun 11, 2021

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Jun 11, 2021
@stale stale bot closed this as completed Jun 22, 2021
@sapegin sapegin reopened this Jun 24, 2021
@stale stale bot removed the wontfix label Jun 24, 2021
@stale
Copy link

stale bot commented Oct 2, 2021

😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Consider opening a pull request if you still have this issue or want this feature.

@stale stale bot added the wontfix label Oct 2, 2021
@stale stale bot closed this as completed Apr 16, 2022
@ThomasRoest ThomasRoest unpinned this issue Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant