Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add load-no-partial-leading-underscore rule. #867

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add load-no-partial-leading-underscore rule. #867

merged 2 commits into from
Oct 24, 2023

Conversation

pamelalozano16
Copy link
Contributor

Fix #859.

@pamelalozano16 pamelalozano16 changed the title Add load-no-partial-leading-underscore rule. Add load-no-partial-leading-underscore rule. Oct 5, 2023
@pamelalozano16 pamelalozano16 force-pushed the load-no-partial-leading-underscore branch 2 times, most recently from 7f981e6 to 17bf8e4 Compare October 5, 2023 00:35
@pamelalozano16 pamelalozano16 force-pushed the load-no-partial-leading-underscore branch from 17bf8e4 to 12eb2df Compare October 24, 2023 18:17
@pamelalozano16 pamelalozano16 force-pushed the load-no-partial-leading-underscore branch from 12eb2df to 88daa13 Compare October 24, 2023 18:20
@kristerkari kristerkari mentioned this pull request Oct 24, 2023
Merged
@kristerkari
Copy link
Collaborator

Could you please also edit the main README of this repo?

  1. The at-import-no-partial-leading-underscore rule needs to be marked as (deprecated) in the README listing
  2. A new "Load" category needs to be added and the load-no-partial-leading-underscore rule under it.

@pamelalozano16 pamelalozano16 force-pushed the load-no-partial-leading-underscore branch from 88daa13 to 7944515 Compare October 24, 2023 20:49
@pamelalozano16 pamelalozano16 force-pushed the load-no-partial-leading-underscore branch from 7944515 to 080b633 Compare October 24, 2023 20:51
@pamelalozano16
Copy link
Contributor Author

@kristerkari Thanks for the review! All done. I added a section of Deprecated rules, let me know if that looks ok please. Thanks!

kristerkari
kristerkari approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@kristerkari kristerkari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now 👍

I'll do the release tomorrow as I need to go to sleep now 🙂

@kristerkari kristerkari merged commit 2205f15 into stylelint-scss:master Oct 24, 2023
11 checks passed
@tagliala tagliala mentioned this pull request Nov 1, 2023
Closed
@adammccullagh adammccullagh mentioned this pull request Jan 10, 2024
Merged
@kristerkari kristerkari mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristerkari kristerkari kristerkari approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate at-import-no-partial-leading-underscore and add load-no-partial-leading-underscore.
2 participants
@pamelalozano16 @kristerkari