stylelint · May 24, 2022 · May 24, 2022 · May 24, 2022 · May 24, 2022 · May 24, 2022
Showing with 73 additions and 47 deletions.

+4 −0 CHANGELOG.md

+1 −1 docs/maintainer-guide/releases.md

+13 −0 lib/rules/no-duplicate-selectors/__tests__/index.js

+10 −1 lib/rules/no-duplicate-selectors/index.js

+42 −42 package-lock.json

+3 −3 package.json
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project are documented in this file.
 
+## 14.8.4
+
+- Fixed: `no-duplicate-selectors` error with non-standard selectors ([#6106](https://github.com/stylelint/stylelint/pull/6106)).
+
 ## 14.8.3
 
 - Fixed: `no-invalid-*` end positions ([#6072](https://github.com/stylelint/stylelint/pull/6072)).

diff --git a/docs/maintainer-guide/releases.md b/docs/maintainer-guide/releases.md
@@ -43,5 +43,5 @@
 - [ ] stylelint.io update
 - [ ] tweet
 
-cc @stylelint/core
+cc @stylelint/owners
 ```
diff --git a/lib/rules/no-duplicate-selectors/__tests__/index.js b/lib/rules/no-duplicate-selectors/__tests__/index.js
@@ -347,3 +347,16 @@ testRule({
 		},
 	],
 });
+
+testRule({
+	ruleName,
+	customSyntax: 'postcss-scss',
+	config: [true],
+
+	accept: [
+		{
+			code: 'a { background: { color: red } }',
+			description: 'Non standard SCSS nested property',
+		},
+	],
+});
diff --git a/lib/rules/no-duplicate-selectors/index.js b/lib/rules/no-duplicate-selectors/index.js
@@ -5,6 +5,7 @@ const selectorParser = require('postcss-selector-parser');
 
 const findAtRuleContext = require('../../utils/findAtRuleContext');
 const isKeyframeRule = require('../../utils/isKeyframeRule');
+const isStandardSyntaxSelector = require('../../utils/isStandardSyntaxSelector');
 const nodeContextLookup = require('../../utils/nodeContextLookup');
 const parseSelector = require('../../utils/parseSelector');
 const report = require('../../utils/report');
@@ -62,7 +63,11 @@ const rule = (primary, secondaryOptions) => {
 			);
 			const resolvedSelectorList = [
 				...new Set(
-					ruleNode.selectors.flatMap((selector) => resolvedNestedSelector(selector, ruleNode)),
+					ruleNode.selectors.flatMap((selector) => {
+						return isStandardSyntaxSelector(selector)
+							? resolvedNestedSelector(selector, ruleNode)
+							: [];
+					}),
 				),
 			];
 			const normalizedSelectorList = resolvedSelectorList.map((selector) => normalize(selector));
@@ -123,6 +128,10 @@ const rule = (primary, secondaryOptions) => {
 
 			// Or complain if one selector list contains the same selector more than once
 			for (const selector of ruleNode.selectors) {
+				if (!isStandardSyntaxSelector(selector)) {
+					continue;
+				}
+
 				const normalized = normalize(selector);
 
 				if (presentedSelectors.has(normalized)) {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "stylelint",
-  "version": "14.8.3",
+  "version": "14.8.4",
   "description": "A mighty, modern CSS linter.",
   "keywords": [
     "css-in-js",
@@ -132,7 +132,7 @@
     "micromatch": "^4.0.5",
     "normalize-path": "^3.0.0",
     "picocolors": "^1.0.0",
-    "postcss": "^8.4.13",
+    "postcss": "^8.4.14",
     "postcss-media-query-parser": "^0.2.3",
     "postcss-resolve-nested-selector": "^0.1.1",
     "postcss-safe-parser": "^6.0.0",
@@ -168,7 +168,7 @@
     "benchmark": "^2.1.4",
     "common-tags": "^1.8.2",
     "deepmerge": "^4.2.2",
-    "eslint": "^8.15.0",
+    "eslint": "^8.16.0",
     "eslint-config-stylelint": "^15.1.0",
     "eslint-plugin-jest": "^26.2.2",
     "husky": "^8.0.1",