Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives on non-standard syntax in declaration-block-no-* #3380

Closed
gucong3000 opened this issue Jun 9, 2018 · 7 comments
Closed
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@gucong3000
Copy link
Member

gucong3000 commented Jun 9, 2018

Describe the bug? (A clear and concise description of what the bug is)

Error was missed for decl when it not in rule

Which rule, if any, is this issue related to?

declaration-block-no-shorthand-property-overrides
declaration-block-no-duplicate-properties

What CSS is needed to reproduce this issue?

<a style="padding-left: 10px; padding: 20px; padding: 20px;"></a>
import styled from 'styled-components';
const Title = styled.h1`
    padding-left: 10px;
    padding: 20px;
    padding: 20px;
`;

What stylelint configuration is needed to reproduce this issue?

{
  "rules": {
    "declaration-block-no-shorthand-property-overrides": true,
    "declaration-block-no-duplicate-properties": true
  }
}

Which version of stylelint are you using?

all

Does your issue relate to non-standard syntax (e.g. SCSS, nesting, etc.)?

HTML and css-in-js

What did you expect to happen?

Should throw a error.

What actually happened (e.g. what warnings or errors you are getting)?

Error was missed

@hudochenkov

This comment has been minimized.

@gucong3000 gucong3000 changed the title Fix false positives on non-standard syntax in declaration-block-no-shorthand-property-overrides Fix false positives on non-standard syntax in declaration-block-no-* Jun 9, 2018
@gucong3000

This comment has been minimized.

@gucong3000
Copy link
Member Author

gucong3000 commented Jun 9, 2018

Related to: emotion-js/emotion#686 (comment)

@hudochenkov

This comment has been minimized.

@gucong3000

This comment has been minimized.

@alexander-akait
Copy link
Member

WIP

@jeddy3 jeddy3 added status: wip is being worked on by someone type: bug a problem with a feature or rule labels Jun 10, 2018
@alexander-akait
Copy link
Member

@jeddy3 looks already fixed #3381?

@jeddy3 jeddy3 closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Development

No branches or pull requests

4 participants