Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 15.0.0 #6409

Closed
jeddy3 opened this issue Oct 13, 2022 · 24 comments · Fixed by #6573
Closed

Prepare 15.0.0 #6409

jeddy3 opened this issue Oct 13, 2022 · 24 comments · Fixed by #6573
Labels
status: ready to implement is ready to be worked on by someone type: umbrella a group of related issues

Comments

@jeddy3
Copy link
Member

jeddy3 commented Oct 13, 2022

Discussed:

Pull requests:

There's no fixed date for when this might happen. We'll need to investigate what's possible and what we've time to do.

This is an umbrella issue for tracking our progress and for broad discussions. Let's use the individual issues for specific discussions.

Ref: Some initial discussion in #6311.

@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: umbrella a group of related issues labels Oct 13, 2022
@ybiquitous
Copy link
Member

@jeddy3 Thanks for listing up the tasks.

It seems we can remove the deprecated syntax option. Is there a related issue?

/** @deprecated Use `customSyntax` instead. Using this option will result in an error. */
syntax?: string;

@jeddy3
Copy link
Member Author

jeddy3 commented Oct 17, 2022

It seems we can remove the deprecated syntax option.

I agree.

Is there a related issue?

I don't believe so. Let's create one.

@ybiquitous
Copy link
Member

ybiquitous commented Oct 17, 2022

Thanks. I've opened #6414 and updated this issue description.


EDIT: If further context is necessary, please feel free to add it to the description of #6414.

@ybiquitous
Copy link
Member

I've created the v15 branch just now. Let's push all the breaking changes into the branch.

@ybiquitous
Copy link
Member

I've cleaned up some tasks. Thank you for your reviews, @jeddy3.

The ESM task is the biggest, so I believe it's recommended to work on the task after reducing the code as possible.

@Mouvedia
Copy link
Contributor

Mouvedia commented Nov 18, 2022

If the rules are dropped and not just deprecated, I think #6483 should be added to the list of the blocking issues.

@ybiquitous
Copy link
Member

I've added #6483 to the list above.

@ntwb
Copy link
Member

ntwb commented Nov 20, 2022

⭐ Stylelint hit 10,000 stars this weekend

@jeddy3
Copy link
Member Author

jeddy3 commented Nov 28, 2022

@ybiquitous The ESM task is the biggest, so I believe it's recommended to work on the task after reducing the code as possible.

Yes, I agree that the ESM task is extensive and we'll want to reduce the code first.

I suggest we move the ESM task to v16. I think dropping support for node 12 and deprecating a lot of stylistic rules is enough for this major release.

In a few months, we can release v16 to:

  • remove the rules we deprecate in v15
  • migrate to ESM

That way we'll allow the:

  • dust to settle on the rule deprecations
  • migration of a smaller code base to ESM

What do you think?

@jeddy3 jeddy3 mentioned this issue Nov 28, 2022
6 tasks
@ybiquitous
Copy link
Member

I suggest we move the ESM task to v16.

Good idea! 👍🏼

@ybiquitous
Copy link
Member

@jeddy3
Copy link
Member Author

jeddy3 commented Dec 23, 2022

@ybiquitous Great job getting everything prepared! I'd like to give the documentation a once-over before we release 15.0.0 to clearly communicate to our users the direction Stylelint is going in. It's the holiday season here, but I hope to find time in the next week or so to do this.

@ybiquitous
Copy link
Member

@jeddy3 Thank you. I'll test packages depending on Stylelint as long as time permits.

@hudochenkov
Copy link
Member

Folks, did you consider deprecate support of Node.js 14 in v15? Node.js 14 end of life is on 2023-04-30.

@ybiquitous
Copy link
Member

ybiquitous commented Jan 5, 2023

Oh, we have four months left! 😳 But I think dropping v14 is challenging because many packages still support v14.

@jeddy3
Copy link
Member Author

jeddy3 commented Jan 5, 2023

Folks, did you consider deprecate support of Node.js 14 in v15?

Let's drop it in v16.

I'd like to give the documentation a once-over

(FYI, I'll hopefully have the v15 docs done in a few days.)

@ybiquitous ybiquitous linked a pull request Jan 11, 2023 that will close this issue
@jeddy3
Copy link
Member Author

jeddy3 commented Jan 19, 2023

We're not far off from being ready to release 15.0.0.

We need to get this two pull requests in:

Then I'll resolve the conflicts and address suggestions in:

We can then decide if we want to include that rule or not.

We'll also want to add deprecating postcss-css-in-js to our release steps as it's tied in the removed processors config property.

I should have time over the coming weeks to help see the release through.

@henryruhs
Copy link
Contributor

henryruhs commented Jan 20, 2023

What about a 15.0.0.next-1 release so plugin authors can pre-check it? I would love to test the ESM compatibility as this is a blocker for me to move to a modern codebase.

@jeddy3
Copy link
Member Author

jeddy3 commented Jan 20, 2023

What about a 15.0.0.next-1 release so plugin authors can pre-check it?

Sure, no harm in a pre-release. It'll also make it easier for us all to test against our CSS codebases.

I would love to test the ESM compatibility as this is a blocker for me to move to a modern codebase.

I don't believe there's anything in 15.0.0 that changes ESM compatibility. The changes we're making (removing the processors config property, deprecating stylistic rules, etc) are a stepping stone to let us better assess if migrating to ESM (#5291) is viable. It'll be a large undertaking.

@ybiquitous
Copy link
Member

We'll also want to add deprecating postcss-css-in-js to our release steps as it's tied in the removed processors config property.

Agreed 👍🏼

What about a 15.0.0.next-1 release so plugin authors can pre-check it?

No objections. We can also try the pre-released code by installing the v15 branch directly from the GitHub repo:

npm install "github:stylelint/stylelint#v15"

@ybiquitous
Copy link
Member

Close via #6573

The last one toward v15 should be #6425.

@jeddy3
Copy link
Member Author

jeddy3 commented Jan 30, 2023

The last one toward v15 should be #6425.

And #6511.

@ybiquitous
Copy link
Member

And #6511.

Sorry, I missed it. I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to implement is ready to be worked on by someone type: umbrella a group of related issues
Development

Successfully merging a pull request may close this issue.

6 participants