Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string-quotes for rules that require quote fixes #6577

Closed
Mouvedia opened this issue Jan 14, 2023 · 1 comment
Closed

Use string-quotes for rules that require quote fixes #6577

Mouvedia opened this issue Jan 14, 2023 · 1 comment
Labels
status: needs discussion triage needs further discussion

Comments

@Mouvedia
Copy link
Contributor

Mouvedia commented Jan 14, 2023

Reason

see #6558 (comment)

What Stylelint configuration is needed to reproduce the bug?

{
  "rules": {
    "function-url-quotes": "always",
    "string-quotes": "single",
  }
}

Challenges

Deprecation

string-quotes is a deprecated rule so the source of the data will disappear.
i.e. if we are not using the value of string-quotes we need to add an option to :

  • font-family-name-quotes
  • selector-attribute-quotes
  • function-url-quotes
  • etc.

Or don't deprecate string-quotes rule.

Order

Does the order matter?
i.e. when using --fix do we require to have set string-quotes before the rules that depends on the non-default value—'?

{
  "rules": {
    "string-quotes": "single",
    "function-url-quotes": "always",
  }
}
@Mouvedia Mouvedia added the status: needs discussion triage needs further discussion label Jan 14, 2023
@jeddy3
Copy link
Member

jeddy3 commented Jan 19, 2023

Let's stick with the current behaviour. We default to double quotes when autofixing and people can use their pretty-printer of choice to convert them if neccesary. Going forward, Stylelint isn't concerned with the type of quote, but rather where they occur.

@jeddy3 jeddy3 closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion triage needs further discussion
Development

No branches or pull requests

2 participants