Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declaration-block-no-redundant-longhand-properties false negatives for inset shorthand #6613

Closed
Mouvedia opened this issue Feb 5, 2023 · 10 comments · Fixed by #6699
Closed
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule

Comments

@Mouvedia
Copy link
Member

Mouvedia commented Feb 5, 2023

Demand

top: 0;
right: 0;
bottom: 0;
left: 0;

should get fixed to

inset: 0;

i.e. add inset property to this list

prompted by #6580 (comment)

@Mouvedia Mouvedia added type: bug a problem with a feature or rule good first issue is good for newcomers labels Feb 5, 2023
@Mouvedia Mouvedia changed the title Add inset short support to declaration-block-no-redundant-longhand-properties Add inset shorthand support to declaration-block-no-redundant-longhand-properties Feb 5, 2023
@DeRaowl
Copy link

DeRaowl commented Feb 5, 2023

Hi @Mouvedia , I have gone through the issue and can I work on this one?

@Mouvedia
Copy link
Member Author

Mouvedia commented Feb 5, 2023

@DeRaowl normally you should wait for the status: ready to implement label to be added to the issue.
@jeddy3 can I add it?

one caveat though: if you start before #6580 merge, you will have to refactor your code

@DeRaowl
Copy link

DeRaowl commented Feb 5, 2023

Ack, will wait for the status to be updated. Thank you.

@Mouvedia
Copy link
Member Author

Mouvedia commented Feb 5, 2023

@DeRaowl Meanwhile you can read about how to fix a bug in a rule in the developer guide and check the 8 good first issues that are ready to be implemented.

@jeddy3 jeddy3 changed the title Add inset shorthand support to declaration-block-no-redundant-longhand-properties Fix declaration-block-no-redundant-longhand-properties false negatives for inset shorthand Feb 6, 2023
@jeddy3
Copy link
Member

jeddy3 commented Feb 6, 2023

@Mouvedia Thanks for creating the issue.

@DeRaowl Thanks for offering to work on it.

one caveat though: if you start before #6580 merge, you will have to refactor your code

Let's wait until #6580 is merged before starting

@jeddy3 jeddy3 added status: blocked is blocked by another issue or pr status: ready to implement is ready to be worked on by someone and removed status: blocked is blocked by another issue or pr labels Feb 6, 2023
@DeRaowl
Copy link

DeRaowl commented Feb 16, 2023

@jeddy3 can I pick this issue?

@ybiquitous
Copy link
Member

@DeRaowl Yeah, of course!

@jeddy3 jeddy3 added status: wip is being worked on by someone and removed status: ready to implement is ready to be worked on by someone labels Feb 16, 2023
@hail2u
Copy link

hail2u commented Mar 4, 2023

I think the rule is also false negative for (border|margin|padding)-(block|inline). For example:

margin-block-end: 0;
margin-block-start: 0;

should be:

margin-block: 0;

@Mouvedia
Copy link
Member Author

Mouvedia commented Mar 4, 2023

It's been more than 2 weeks, it's available again.

@Mouvedia Mouvedia added status: ready to implement is ready to be worked on by someone and removed status: wip is being worked on by someone labels Mar 4, 2023
@rayrw
Copy link
Contributor

rayrw commented Mar 7, 2023

Hi, I'd like to pick this one if it's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule
Development

Successfully merging a pull request may close this issue.

6 participants