Fix overrides.files negated pattern regression

[emmasax]

What minimal example or steps are needed to reproduce the bug?

Create file fontSizeAllowedFile.tsx:

import { css } from '@emotion/react';

export const someStyling = css`
  font-size: 16px;
  color: white;
`;

What minimal configuration is needed to reproduce the bug?

Using glob pattern to exclude files (!(files)) does not work in Stylelint 15. It does work in previous versions.

Using the positive glob does include only this file ["*/**/fontSizeAllowedFile.tsx"], just negating it does not work.

{
  "customSyntax": "postcss-styled-syntax",
  "rules": {
    "property-disallowed-list": null
  },
  "overrides": [
    {
      "files": ["!(*/**/fontSizeAllowedFile.tsx)"],
      "rules": {
        "property-disallowed-list": ["font-size", "font-weight"]
      }
    }
  ]
}

How did you run Stylelint?

Via nx stylelint command

Which Stylelint-related dependencies are you using?

{
    "postcss-styled-syntax": "^0.4.0",
    "stylelint": "^15.10.1",
    "stylelint-config-standard": "^33.0.0"
}

What did you expect to happen?

File should not run disallowed list on the excluded file.

What actually happened?

File is not excluded

 4:3  ✖  Unexpected property "font-size"    property-disallowed-list

Do you have a proposal to fix the bug?

No response

[Mouvedia]

I guess it's just a matter of doing a git bisect, if it used to work.
The only PR I found which looks related is #​6547.

[jeddy3]

@emmasax Thanks for the detailed report and for using the template.

I can reproduce this locally with:

{
  "rules": {
    "color-no-invalid-hex": null
  },
  "overrides": [
    {
      "files": ["!(*/**/test.css)"],
      "rules": {
        "color-no-invalid-hex": true
      }
    }
  ]
}

/* /test/test.css */
a {
  color: #00;
}

15.10.1:

jeddy3@mac stylelint-test % npx stylelint "**/*.css"

test/test.css
 2:10  ✖  Unexpected invalid hex color "#00"  color-no-invalid-hex

1 problem (1 error, 0 warnings)

14.16.1:

jeddy3@mac stylelint-test % npx stylelint "**/*.css"
(no warnings)

I've labelled the issue as ready to implement. Please consider contributing if you have time. It may require a bit of digging, though.

[ybiquitous]

Sorry for the late response. As @Mouvedia guessed, I produced this bug through PR #6547. The bug is at:

stylelint/lib/augmentConfig.mjs

Lines 394 to 398 in d881c9d

	// E.g. `*.css` matches any CSS files in any directories.
	micromatch.isMatch(filePath, files, { dot: true, basename: true })
	) {
	config = mergeConfigs(config, configOverrides);
	}

Here's a simple confirmation. Returning true by isMatch() for negation patterns (e.g. !(**/test.css)) adds an input file path (e.g. /foo/test.css) to lint targets.

micromatch = require('micromatch');
micromatch.isMatch('/foo/test.css', ['!(**/test.css)'], { dot: true, basename: true });
//=> true

I'll create a patch pull request soon.

However, this glob's syntax/behavior depends on a glob library (currently micromatch and is undocumented in the Stylelint document. So, I recommend using ignoreFiles instead for clarity and stability. E.g.

{
-	files: ['!(**/test.css)'],
+	files: ['**/*.css'],
+	ignoreFiles: ['**/test.css'],
}