Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow part ident falsly parsed as type selector #4828

Merged
merged 1 commit into from Jun 16, 2020

Conversation

runarberg
Copy link
Contributor

Which issue, if any, is this issue related to?

Fixes #4822

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks for the pull request and your first contribution to stylelint. Looks good to me!

@jeddy3 jeddy3 merged commit 1404260 into stylelint:master Jun 16, 2020
@jeddy3
Copy link
Member

jeddy3 commented Jun 16, 2020

Changelog

  • Fixed: selector-type-no-unknown false positives for idents within ::part pseudo-elements (#4828).

m-allanson added a commit that referenced this pull request Jun 20, 2020
# By jeddy3 (4) and others
# Via GitHub
* master:
  Create new 'prepareReturnValue' module (#4832)
  13.6.1
  Scope eslint disable
  Prepare 13.6.1
  Update deps
  Update CHANGELOG.md
  Fix false positives for idents within ::part pseudo-elements in selector-type-no-unknown (#4828)
  Bump np from 6.2.3 to 6.2.4 (#4830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix false positives for idents within ::part pseudo-elements in selector-type-no-unknown
3 participants