Add support for descriptions in stylelint command comments #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Overall I think this looks great!
One quick thing: as mentioned in the issue discussion, we should add a quick note in the rules documentation that the double hyphen introduces a comment, and therefore a rule name should never have a double hyphen in it.
Other than that, I don't see anything else to change in this PR, though more reviewers is always great. Thanks for the addition @glen-84!
|
We decided to switch to a delimiter with a space on either side, so it should not affect rule names containing double hyphens. An extreme edge case would be a rule named just |
mattxwang
approved these changes
Jul 1, 2020
|
Changelog:
|
m-allanson
added a commit
that referenced
this pull request
Jul 8, 2020
# By Richard Hallows (4) and others # Via GitHub * master: Create codeql analysis workflow (#4850) Update CHANGELOG.md Add support for descriptions in stylelint command comments (#4848) Update CHANGELOG.md Add *-allowed-list/*-disallowed-list/*-required-list names for *-whitelist/*-blacklist/*-requirelist rules (#4845) Update CHANGELOG.md Add syntax object acceptance to customSyntax option (#4839) Bump typescript from 3.9.5 to 3.9.6 (#4853) Add ignoreComments[] to comment-empty-line-before (#4841) Bump autoprefixer from 9.8.0 to 9.8.2 (#4838)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4840.
Let me know if there is.