New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid combining disable comments with a blank line #4913
Conversation
bb54948
to
eb3b04a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for a quick fix!
Thanks for the fix! Changelog entry added:
|
* master: (34 commits) Update CHANGELOG.md Fix double-slash disable comments when followed by another comment (#4913) Update CHANGELOG.md (#4916) 13.7.0 Prepare 13.7.0 Prepare changelog Update dependencies Update CHANGELOG.md Deprecate *-blacklist/*-requirelist/*-whitelist (#4892) Fix some path / glob problems (#4867) Update CHANGELOG.md Add a reportDescriptionlessDisables flag (#4907) Fix CHANGELOG.md format via Prettier (#4910) Fix callbacks in tests (#4903) Update CHANGELOG.md Fix false positives for trailing combinator in selector-combinator-space-after (#4878) Add coc-stylelint (#4901) Update CHANGELOG.md Add support for *.cjs config files (#4905) Add a reportDisables secondary option (#4897) ...
Could this be released as 13.7.1? :) |
until the fix from stylelint/stylelint#4913 is released...
It seems we still get failures even with this patch: https://github.com/twbs/bootstrap/runs/1110881505. I'll try to pinpoint the cause, but going back to 13.6.1 works fine again. |
This PR fixed it for cases where the Adding an empty line between the 2 comments should fix it with 13.7.1. |
Thanks for the reply. That does seem to be the case. Although, ideally, this should be handled too because it is a regression. |
@XhmikosR I created an new issue for the remaining regression |
Fixes #4911.
This checks line numbers before combining adjacent
//
comments.