Add media-feature-name-unit-allowed-list
#6550
Conversation
Adds base rule, refactors slightly from @romainmenke's suggestion; adds docs, rudimentary tests. Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
馃 Changeset detectedLatest commit: 61e2dd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Required a bit of hardcoding?
lib/rules/media-feature-name-unit-allowed-list/__tests__/index.js
Outdated
Show resolved
Hide resolved
| index: atRuleIndex + childEntry.node.value[2], | ||
| endIndex: atRuleIndex + childEntry.node.value[3] + 1, |
There was a problem hiding this comment.
Two "hardcoded" values indicated by @romainmenke.
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
Co-authored-by: Marc G. <Mouvedia@users.noreply.github.com>
lib/rules/media-feature-name-unit-allowed-list/__tests__/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
No behaviour changes. Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
|
Thank you for the in-depth review @ybiquitous, appreciate your attention to detail and good eye for readability. I believe I've addressed all the comments for this PR (tabling conversations about the Also, this is an oversight on my part - should we be merging this into |
There was a problem hiding this comment.
@mattxwang Thank you so much for addressing the reviews. Yes, the v15 branch is suitable as a base. LGTM 馃憤馃徏
Closes #6509.
@romainmenke has asked a question about warning on values with no unit; my assumption is no, but I'd love to get that checked!
I've also left some notes where I could use some guidance. Since I'm still a relatively junior contributor (and I'm a bit rusty 馃槗 ), any advice is appreciated!
And, given all of their help, would be great to include the co-author commit for @romainmenke!