Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes at-rule-no-unknown false positives for @scroll-timeline #6554

Merged
merged 4 commits into from Jan 4, 2023

Conversation

mattxwang
Copy link
Member

Which issue, if any, is this issue related to?

Closes #6548.

Is there anything in the PR that needs further explanation?

Pretty self-explanatory - added failing test case, then used @Mouvedia's proposed solution.

Added failing test case, added `@scroll-timeline` to `atKeywords`
@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2023

🦋 Changeset detected

Latest commit: f47e3eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👍🏼

.changeset/nice-ligers-type.md Outdated Show resolved Hide resolved
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@ybiquitous ybiquitous merged commit 5e6d46a into main Jan 4, 2023
@ybiquitous ybiquitous deleted the fix-at-rule-no-unknown-scroll-timeline-fp branch January 4, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix at-rule-no-unknown false positives for @scroll-timeline
3 participants