From 7626a4bce4477113ec4118ed57bc4397e876001a Mon Sep 17 00:00:00 2001 From: Matthew Wang Date: Tue, 3 Jan 2023 15:10:21 -0800 Subject: [PATCH 1/4] Fixes `at-rule-no-unknown` false positives for `@scroll-timeline` Added failing test case, added `@scroll-timeline` to `atKeywords` --- lib/reference/atKeywords.js | 1 + lib/rules/at-rule-no-unknown/__tests__/index.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/reference/atKeywords.js b/lib/reference/atKeywords.js index 40fecce563..5773d14ea1 100644 --- a/lib/reference/atKeywords.js +++ b/lib/reference/atKeywords.js @@ -44,6 +44,7 @@ const atKeywords = uniteSets(pageMarginAtKeywords, [ 'ornaments', 'page', 'property', + 'scroll-timeline', 'styleset', 'stylistic', 'supports', diff --git a/lib/rules/at-rule-no-unknown/__tests__/index.js b/lib/rules/at-rule-no-unknown/__tests__/index.js index 3639493d05..1923ff3ee0 100644 --- a/lib/rules/at-rule-no-unknown/__tests__/index.js +++ b/lib/rules/at-rule-no-unknown/__tests__/index.js @@ -91,6 +91,9 @@ testRule({ { code: '@layer framework { h1 { background: white; } }', }, + { + code: '@scroll-timeline spin-slash { }', + }, ], reject: [ From 8e8a447f8cab296833352712a86de570cce3ad0e Mon Sep 17 00:00:00 2001 From: Matthew Wang Date: Tue, 3 Jan 2023 15:12:20 -0800 Subject: [PATCH 2/4] Adds changeset --- .changeset/nice-ligers-type.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nice-ligers-type.md diff --git a/.changeset/nice-ligers-type.md b/.changeset/nice-ligers-type.md new file mode 100644 index 0000000000..c659957283 --- /dev/null +++ b/.changeset/nice-ligers-type.md @@ -0,0 +1,5 @@ +--- +"stylelint": patch +--- + +Fixes `at-rule-no-unknown` false positives for `@scroll-timeline` From d5587af1c45829f3c19923739ff2cc739b9a8fb3 Mon Sep 17 00:00:00 2001 From: Matthew Wang Date: Tue, 3 Jan 2023 16:06:28 -0800 Subject: [PATCH 3/4] adjusts new test case to better match developer conventions --- lib/rules/at-rule-no-unknown/__tests__/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/at-rule-no-unknown/__tests__/index.js b/lib/rules/at-rule-no-unknown/__tests__/index.js index 1923ff3ee0..abc72bcf37 100644 --- a/lib/rules/at-rule-no-unknown/__tests__/index.js +++ b/lib/rules/at-rule-no-unknown/__tests__/index.js @@ -92,7 +92,7 @@ testRule({ code: '@layer framework { h1 { background: white; } }', }, { - code: '@scroll-timeline spin-slash { }', + code: '@scroll-timeline foo {}', }, ], From f47e3ebec81906320b3db1673f6d90362020a308 Mon Sep 17 00:00:00 2001 From: Matt Wang Date: Tue, 3 Jan 2023 18:01:41 -0800 Subject: [PATCH 4/4] Update changeset to match naming convention Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> --- .changeset/nice-ligers-type.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/nice-ligers-type.md b/.changeset/nice-ligers-type.md index c659957283..b0410b1cc2 100644 --- a/.changeset/nice-ligers-type.md +++ b/.changeset/nice-ligers-type.md @@ -2,4 +2,4 @@ "stylelint": patch --- -Fixes `at-rule-no-unknown` false positives for `@scroll-timeline` +Fixed: `at-rule-no-unknown` false positives for `@scroll-timeline`