Fix isStandardSyntaxFunction false positives for interpolation and backticks in CSS-in-JS
#6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icks in CSS-in-JS. Fixes #6564
🦋 Changeset detectedLatest commit: 221dbaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hudochenkov
commented
Jan 8, 2023
ybiquitous
reviewed
Jan 9, 2023
hudochenkov
changed the title
function-no-unknown false positives for interpolation and backticks in CSS-in-JS. Fixes #6564isStandardSyntaxFunction false positives for interpolation and backticks in CSS-in-JS. Fixes #6564
|
@ybiquitous I agree with your suggestion. I've updated PR title, but I don't think we need to mention internal function in a changelog. Because users don't care about internal functions, but they care about rules. |
ybiquitous
changed the title
isStandardSyntaxFunction false positives for interpolation and backticks in CSS-in-JS. Fixes #6564isStandardSyntaxFunction false positives for interpolation and backticks in CSS-in-JS
ybiquitous
approved these changes
Jan 10, 2023
43081j
reviewed
Jan 10, 2023
| it('CSS-in-JS interpolation', () => { | ||
| expect( | ||
| isStandardSyntaxFunction( | ||
| getFunction('${({ size }) => (size === "small") ? "0.8em" : "1em"}'), |
There was a problem hiding this comment.
this is great, exactly what i was getting at in the other issue - a generic test for all css-in-js function nodes.
nice work 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6564
Tests for the rule are skipped, because there is no CSS-in-JS syntax added to the repo yet.
Waiting for #6556.