New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignoreFunctions: []
to unit-disallowed-list
#6592
Conversation
🦋 Changeset detectedLatest commit: 5449cd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the PR! Please consider addressing the reviews.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Thank you for the quick review @ybiquitous! Upon reflection, I should have been more careful before submitting this PR - the slip-ups are 100% on me. Appreciate the feedback! I think I've addressed each comment; let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the reviews. I've left a few suggestions.
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM! 👍🏼
…#6594) Quick fix: make "given" example consistent See: #6592 (comment)
Closes #6574.
Hopefully not!