Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector-not-notation autofix for "simple" option #6608

Merged
merged 1 commit into from Feb 4, 2023

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Feb 3, 2023

Which issue, if any, is this issue related to?

Closes #6606

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: ecce475

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mouvedia Mouvedia force-pushed the mouvedia-6606 branch 5 times, most recently from c698524 to 5df9f9c Compare February 3, 2023 03:51
@Mouvedia Mouvedia marked this pull request as ready for review February 3, 2023 03:52
@ybiquitous ybiquitous changed the title fix #6606 Fix selector-not-notation autofix for "simple" option Feb 3, 2023
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mouvedia Thanks for creating the pull request.
I've left a refactoring suggestion, but the direction looks good to me. 👍🏼

lib/rules/selector-not-notation/index.js Outdated Show resolved Hide resolved
lib/rules/selector-not-notation/index.js Outdated Show resolved Hide resolved
@Mouvedia Mouvedia marked this pull request as draft February 4, 2023 10:38
@Mouvedia Mouvedia marked this pull request as ready for review February 4, 2023 11:06
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeddy3 jeddy3 merged commit 3358401 into stylelint:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix selector-not-notation autofix for "simple"
3 participants