Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Class name blacklist #350

Open
Tylerian opened this issue Nov 1, 2019 · 1 comment
Open

[suggestion] Class name blacklist #350

Tylerian opened this issue Nov 1, 2019 · 1 comment

Comments

@Tylerian
Copy link

Tylerian commented Nov 1, 2019

Problem

When using Styletron paired with other css libraries that uses short class names as their namespace, there could be a collision in their class names.

An example of this is Fontawesome. They use the .fa class name as one of their base styles, so when Styletron generates a .fa class name, a bug arises and broken designs may appear.

Solution

We could feed Styletron Atomic with an user-configurable class name blacklist so it can take into account potential collisions when generating classnames.

@Tylerian
Copy link
Author

Tylerian commented Nov 3, 2019

Okay so I've just re-read the docs and found the prefix option, It fixes the issue i've faced at the cost of longer class names.

Perhaps this suggestion is still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant