Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dep for css-parse #2569

Closed
jnardone opened this issue Dec 3, 2020 · 3 comments · Fixed by #2554
Closed

Remove dep for css-parse #2569

jnardone opened this issue Dec 3, 2020 · 3 comments · Fixed by #2554
Labels
dependencies Pull requests that update a dependency file t: Enhancement

Comments

@jnardone
Copy link

jnardone commented Dec 3, 2020

css-parse is a dumb package. -> https://github.com/reworkcss/css-parse

all it does is:
module.exports = require('css').parse;

It hasn't been updated in 7 years, and it pulls in css anyway, so just pull in css into this library and stop using this. This ALSO lets you move to css version 3.0.0, which fixes some old deprecations.

@vendethiel
Copy link
Contributor

well, it's a holdover from when css-parse was actually parsing CSS, and not just that.

@muuvmuuv
Copy link

Yes please move to css directly to remove the deprecation warning from urix which is resolved in the latest css version.

@iChenLei iChenLei added dependencies Pull requests that update a dependency file t: Enhancement labels Aug 21, 2021
@iChenLei
Copy link
Member

Will release a new version later, PR #2554 for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file t: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants