Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deg and fr as exceptions for 0 value unit omission #2578

Merged
merged 3 commits into from Sep 1, 2021

Conversation

groenroos
Copy link
Collaborator

Fix #2570 where fr and deg units are omitted when --compress is on, which results in invalid CSS.

lib/visitor/compiler.js Outdated Show resolved Hide resolved
Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @xdan

@iChenLei iChenLei merged commit 7334567 into stylus:dev Sep 1, 2021
@groenroos groenroos deleted the fix-0fr-and-0deg branch September 1, 2021 10:56
@iChenLei
Copy link
Member

iChenLei commented Sep 4, 2021

@groenroos release v0.55.0 just now, if you are interested in stylus maintenance, more pr welcome. anyway, thanks you for your contributation.

@groenroos
Copy link
Collaborator Author

@iChenLei Amazing! 🎉 I'll try to help where I can, I don't want to see this great project languish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0fr is erroneously compressed to 0
2 participants