Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization not working on Windows #7

Closed
styxlab opened this issue Dec 26, 2020 · 3 comments
Closed

Normalization not working on Windows #7

styxlab opened this issue Dec 26, 2020 · 3 comments

Comments

@styxlab
Copy link
Owner

styxlab commented Dec 26, 2020

@beatplus moved your comment to a new issue:

If your development environment is run in Windows, there is a bug in Nextjs path rendering. #4 fixes this

@styxlab
Copy link
Owner Author

styxlab commented Dec 26, 2020

This project actively supports Linux and WSL (Windows Subsystem for Linux), so I am not yet sure how much effort I can put into Windows. I'd be surprised if #4 is the only change needed to make things work on native Windows. There might be other places in the code, where fore-slashes are used (there are also calls to the file-system).

Therefore, before merging this PR I'd like to get a better overview what is needed here to fully support Windows. If you could identify the places that need to be changed/checked: that would be great. I also welcome any proposals on how this repo can sustainably support Windows, maybe we need to implement some automatic tests for that?

As a side note, I am also wandering if this problem is better solved upstream. See nodejs/node#35477

@mtaberna
Copy link
Contributor

Thanks @styxlab , I managed to get my development environment running but your guess that something else must be broken is valid. I will migrate to WSL but I will commit in this PR additional bug fixes that I spot

@styxlab
Copy link
Owner Author

styxlab commented Dec 26, 2020

@beatplus Super that you can give WSL a try - it's a much better experience when working with this repo but also with other nodejs driven applications. I will close the PR, but you can always open a new issue (or PR) for your upcoming findings. Thanks a lot for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants