Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build with Tycho due to SqlJet Environment #169

Open
dorothy-agilemind opened this issue Mar 20, 2021 · 3 comments
Open

Cannot build with Tycho due to SqlJet Environment #169

dorothy-agilemind opened this issue Mar 20, 2021 · 3 comments

Comments

@dorothy-agilemind
Copy link

Hello,
In the MANIFEST.MF of the osgi plugin org.tmatesoft.sqljet (which is packaged in the org.tmatesoft.svnkit Eclipse feature), there is an incorrect Bundle-ExecutionEnvironment.
The MANIFEST.MF of latest versions states

Bundle-RequiredExecutionEnvironment: JavaSE-1.5

whereas it should state J2SE-1.5 according to https://docs.osgi.org/reference/eenames.html
This was correct in the SQLJet 1.1.10 brought by SVNKit 1.8.5, but has regressed since then.

The unfortunate consequence is that one can not use SVNKit in a Tycho build, or it will fail with

org.apache.maven.InternalErrorException: Internal error: org.eclipse.tycho.core.osgitools.OsgiManifestParserException: Exception parsing OSGi MANIFEST /var/lib/jenkins/.m2/repository/p2/osgi/bundle/org.tmatesoft.sqljet/1.1.13.r1341/org.tmatesoft.sqljet-1.1.13.r1341.jar!/META-INF/MANIFEST.MF: Unknown OSGi execution environment: ‘JavaSE-1.5’

Would it be possible to fix it back to J2SE-1.5, or to consider upgrading it to JavaSE-1.6 (same as org.tmatesoft.svnkit) instead ?
Thanks in advance.

@markphip
Copy link
Contributor

We are just a downstream consumer of this library. It comes from https://svnkit.com

The last few years they have been less responsive about fixing things but it would not hurt to try to post a bug report to them. If they would just publish a p2 repository we could just pull directly from them. In the past I have given them this suggestion and showed them how to do it.

@sewe
Copy link

sewe commented Apr 27, 2021

The last few years they have been less responsive about fixing things but it would not hurt to try to post a bug report to them. If they would just publish a p2 repository we could just pull directly from them. In the past I have given them this suggestion and showed them how to do it.

For the record, there is a thread in the SVNkit forum about them not publishing a p2 repository: https://support.tmatesoft.com/t/no-repository-found-at-http-eclipse-svnkit-com-1-10-x/2388

That being said, the use of JavaSE-1.5 rather than J2SE-1.5 is discussed in eclipse-tycho/tycho#98, too, although I am not 100% sure whether this is a problem with the SVNKit headers or not. The OSGi spec is a bit vague.

@sewe
Copy link

sewe commented Apr 27, 2021

That being said, the use of JavaSE-1.5 rather than J2SE-1.5 is discussed in eclipse-tycho/tycho#98, too, although I am not 100% sure whether this is a problem with the SVNKit headers or not. The OSGi spec is a bit vague.

Turns out that Tycho is correct and that SVNKit (or rather SQLJet) contains an invalid Bundle-RequiredExecutionEnvironment header. I have reported this upstream already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants