Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoration calculation very slow since update to 4.3 #173

Open
thederingSimus opened this issue May 6, 2021 · 2 comments
Open

Decoration calculation very slow since update to 4.3 #173

thederingSimus opened this issue May 6, 2021 · 2 comments

Comments

@thederingSimus
Copy link

With the current version of subclipse (4.3.3), it takes Eclipse very long to update the status decorations of projects (triggered in my case by selecting working sets). VisualVM shows that java.nio.file.Files.isSymbolicLink() is using nearly all time in the thread doing the decoration calculation, so I guess that this problem comes from the fix for #84 that was introduced in 4.3.0.

Before the update, the status decorations were updated in ~2 seconds even for multiple projects, now it is taking ~10 seconds for one project and increases when more projects are being updated (~50 seconds for 8 projects). Here is a screenshot of VisualVM showing a sampler snapshot:
decorationUpdateSampling

@markphip
Copy link
Contributor

markphip commented May 6, 2021

There are no longer any regular contributors to this project. If someone submits a PR that can fix this issue without breaking the other one I will do what I can to get it merged.

@movedoa
Copy link

movedoa commented Sep 7, 2021

Can we roll back #84? Now we have horrible performance for all decorators instead of a wrong decorator in one specific edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants