Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVNPluginAction delegates not notified of selection change after first instance of commit dialog #278

Open
domlett opened this issue Sep 19, 2023 · 3 comments

Comments

@domlett
Copy link
Contributor

domlett commented Sep 19, 2023

When implementing a plugin that extends org.tigris.subversion.subclipse.ui.commitDialogToolBarActions, the plugin is never notified of selections changes upon new instances of Commit dialog windows.
Using org.eclipse.externaltools.svn.subclipse.action.SVNCommitCompareAction as an example:
Modify a file and bring up the commit dialog window.
Highlight a file, which will enable the compare button.
image
Close the dialog. (commit or cancel, it doesn't matter how it is closed)
Modify a different file and bring up the commit dialog window.
Notice no files are highlighted, but the compare button is enabled.
image
Selecting the button will perform the action on the previously selected file, not the current file(s) in the ResourceSelectionTree.
This is due to the fact the plugin is never notified of the selection change after the first commit dialog is closed.

@t14z
Copy link

t14z commented Sep 19, 2023 via email

@domlett
Copy link
Contributor Author

domlett commented Sep 19, 2023

I'm sure I'm doing something wrong, I'm new to GitHub, I can't seem to create a branch, so I'll attach a patch of the fix.
SVNPluginAction-delegates-not-notified-of-selection-.patch

@markphip
Copy link
Contributor

You need to create a fork of the repository, make the change in your fork and then submit it as a pull request.

Thanks for looking for the fix. This project has not been maintained for years so fixes only happen if someone sends a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants